-
Notifications
You must be signed in to change notification settings - Fork 307
ci: Add arm64 makefile targets. #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ci: Add arm64 makefile targets. #1755
Conversation
| apiVersion: v1 | ||
| fieldPath: metadata.namespace | ||
| image: ghcr.io/fluent/fluent-operator/fluent-operator:v3.5.0 | ||
| image: ghcr.io/fluent/fluent-operator/fluent-operator:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but this resets the tag to latest on master so that CI passes.
Signed-off-by: Josh Baird <[email protected]>
9ab9746 to
e465c94
Compare
marcofranssen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggestions:
- Some targets where copy past errors and still amd64.
- PHONY should be used https://makefiletutorial.com/#phony
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Makefile
Outdated
| docker buildx build --push --platform linux/amd64,linux/arm64 -f cmd/fluent-watcher/fluentbit/Dockerfile.debug . -t ${FB_IMG_DEBUG} | ||
|
|
||
| # Build all amd64 docker images | ||
| PHONY: build-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be . PHONY instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - fixed.
Signed-off-by: Josh Baird <[email protected]>
a82fa47 to
484a96a
Compare
Signed-off-by: Josh Baird <[email protected]>
484a96a to
c16e10e
Compare
Adds
arm64make targets for building arm64 images locally.Example builds of fluent-operator:
arm64:
amd64: